Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix accidential dependencies of rrweb-snapshot #45

Merged
merged 1 commit into from
Feb 8, 2023
Merged

fix: Fix accidential dependencies of rrweb-snapshot #45

merged 1 commit into from
Feb 8, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 8, 2023

jest-environment-jsdom should be in devDependencies.

@mydea
fix: Fix accidential dependencies of rrweb-snapshot
5b3234f 
`jest-environment-jsdom` should be in `devDependencies`.
@mydea mydea requested review from billyvg and Lms24 February 8, 2023 13:30
@mydea mydea self-assigned this Feb 8, 2023
@mydea mydea merged commit a705c3b into sentry-v1 Feb 8, 2023
@mydea mydea deleted the fn/fix-dependencies branch February 8, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@billyvg billyvg Awaiting requested review from billyvg

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @Lms24